-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pan-and-Zoom feature is not working with PhET "Creator" pattern. #769
Comments
From phetsims/equality-explorer#179 (comment), this shows the buggy behavior: |
Noting in phetsims/qa#748 |
This will likely be a problem for geometric-optics, where we drag rulers out of a toolbox. |
When testing phetsims/qa#771, I noticed that pan-and-zoom works when moving an object around the play area. However, if I were to remove an object from a grouping, it will not pan until I release it and grab it again. Also, panning won't happen when an object is initially removed from bucket. |
The overall approach to panning while dragging an object is pretty poor. I am going to reconsider it here first phetsims/scenery#1356 before trying to get what we currently have working with the "Creator" pattern. |
Noting that I'm seeing this issue while testing phetsims/qa#785. |
@jessegreenberg can you please comment on the state of this issue now that phetsims/scenery#1356 is closed? |
I just confirmed that cases like phetsims/build-a-nucleus#23 are not fixed so we still need to solve that. But hopefully it will be easier now that phetsims/scenery#1356 is done. |
Build a Nucleus is getting ready for publication, it'd be nice to take a look at this issue. @jessegreenberg, @zepumph and I would be happy to help. |
Pan and zoom is working well in BAN with changes from phetsims/scenery#1356 once the |
The issue in CCK is caused by phetsims/circuit-construction-kit-common#992, a sim specific issue. Since this pattern has been well supported for a while and the remaining sim specific cases are handled, this issue can be closed. |
Creator is a PhET design pattern used by toolboxes and buckets. When something is dragged out of a toolbox or bucket, a new object is created, with a corresponding model and view. As discovered in phetsims/equality-explorer#179 (comment), if the simulation is zoomed in, then panning does not work while dragging the newly-created object.
In phetsims/equality-explorer#179 (comment), @jessegreenberg confirmed that this is a general problem, and said:
In phetsims/equality-explorer#179 (comment), @KatieWoe also confirmed that this is a general problem, occuring in "a number of sims on master" and "is in phetsims/qa#736 as well".
Assigned to @jessegreenberg to investigate. Please check with @kathy-phet and @amanda-phet for priority.
The text was updated successfully, but these errors were encountered: