-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fontawesome icons in NavigationBarSoundToggleButton #730
Comments
I tracked down the commit that replaced the font-awesome icons and the associated issue, from phetsims/tambo#19 (comment):
Sounds like the two reasons were:
From BASE master: |
@pixelzoom said:
@chrisklus has described the reasons above (thanks for looking at this @chrisklus). I've added a comment with an explanation to the file header. @pixelzoom - Since you opened the issue, please review the response. If you think it's satisfactory, this can be closed. If not, please assign to a designer to decide if we should revisit. |
Noticed while working on phetsims/sherpa#83.
I understand why the navigation bar isn’t using SoundToggleButton — it must be a joist button, hence NavigationBarSoundToggleButton.
But is there a reason why NavigationBarSoundToggleButton isn’t using the fontawesome icons that are used by SoundToggleButton, and is instead drawing complicated shapes that are almost identical to the fontawesome icons? This creates 2 issues: inconsistency of sound icons, and having to maintain complicated shapes.
The text was updated successfully, but these errors were encountered: