incorrect scaling of AboutDialog

[pixelzoom]

Reported in phetsims/ph-scale#168. Possibly related to #586.

AboutDialog scaling is incorrect. Unclear whether this issue is specific to AboutDialog, or is a more general problem with Dialog scaling. There are 2 main problems:

(1) On non-Home screens, long credits can result in the About dialog overlapping the navigation bar, and/or falling off the top of the screen. See screenshot below. Dialogs should always be scaled to fit the ScreenView layoutBounds.

(2) On the Home screen, the dialog size is different than the other screens. See screenshot below. This may be because HomeScreenView.js is using non-standard layoutBounds:

const LAYOUT_BOUNDS = new Bounds2( 0, 0, 768, 504 );

[pixelzoom]

@ariel-phet asked me to apply the scaling workaround from #586 to AboutDialog. I noted that this would result in a smaller About dialog in all sims, as well as the Home screen. And a sim with long credits may still encounter the problem.

A real solution is still needed, probably in connection with #586. Assigning to @ariel-phet to prioritize and assign.

[ariel-phet]

I am currently marking this work deferred. As long as this workaround is working for the moment the work is not a major priority. It is important the about dialog fit within the bounds and everything in it can be read, but the aethetics of this dialog are not of major concern (no effect on pedagogy etc).

A long term solution should be found at some point.

[KatieWoe]

Noting here that the size difference is fairly noticeable and may be difficult to read in cases where there is a lot of text. Should be fine for now, but I will keep an eye out and make an issue if a future sim seems to have too small of text. Seen on master 7/14/2020

[KatieWoe]

Potential example of this in Acid Base Solutions. Has a fairly large amount of text and a home screen where things would be smaller. May not be problematic in this case, but shows how it might get there.
Published:

Master:

[pixelzoom]

Looks like @jonathanolson removed the workaround in 695644f for #586.

Remaining AboutDialog tweaks will be done in #586.

Closing.