Limit width of content in KeyboardHelpDialog

[jessegreenberg]

KeyboardHelpDialog currently assumes that its content will keep the width within the dev bounds. But this means that we generally need to define a max width on the content every time we create a KeyboardHelpDialog. In phetsims/resistance-in-a-wire#203 @jbphet recommended

it seems like it would be better to do this generally so that KeyboardHelpDialog is automatically limited to the dev bounds.

Assigning to myself to investigate.

[jessegreenberg]

This issue is not specific to KeyboardHelpDialog but all Dialogs. Dialogs don't have knowledge of the dev bounds and are often not attached to a ScreenView so it doesn't seem like a Dialog can do this generally.

[jessegreenberg]

What if we have a supertype KeyboardHelpDialogContent that has a default maxWidth that works well for default layout bounds of ScreenView but can be specified as an option for sims that are not using default layout bounds?

[zepumph]

I found phet.sim.joist.screenBoundsProperty (joist-internal) (read-only). What if we just used a percent of that?

[zepumph]

@jessegreenberg please review. Do you think that this kind of solution could work?

[jessegreenberg]

Thanks @zepumph, something like this could work. Dialog has a @private reference to sim so maybe we can make that @protected and use in KeyboardHelpDialog.

Only a single instance of KeyboardHelpDialog is created so the maxWidth will change depending on whether the dialog is opened on the home screen vs a sim screen. Instead of setting on construction maybe we can update the maxWidth on show.

[jessegreenberg]

Ah, I found that Dialog has a layoutStrategy option that has everything that we need!

[jessegreenberg]

I tested this in RIAW, friction, and coulombs-law. @zepumph can you please review?

[zepumph]

This looks awesome! Well done. I will note in friction, and let you handle RIAW.