Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homebutton won't click with keyboard #485

Closed
zepumph opened this issue Apr 19, 2018 · 3 comments
Closed

Homebutton won't click with keyboard #485

zepumph opened this issue Apr 19, 2018 · 3 comments
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Apr 19, 2018

Currently pressing space or enter on HomeButton.js will only blur the button, not click it. Tagging @jessegreenberg because we both saw this today in meetings.
@zepumph
Copy link
Member Author

zepumph commented Apr 19, 2018

Weird logic, if you add a debugger to JoistButton's click listener, then it will work after you play through the debugger.

zepumph added a commit that referenced this issue Apr 19, 2018
@zepumph
fix home button click error, #485
14d927c
@zepumph
Copy link
Member Author

zepumph commented Apr 19, 2018

I removed the blur event that I added to the HomeButton and it fixed this issue. I look through the project, and the blur event isn't really used in other places, especially no buttons. @jessegreenberg please review.

@jessegreenberg
Copy link
Contributor

Thanks @zepumph, looks good and I verified that this fixed the problem. Ill bet the blur was necessary prior to our work in AccessibleInstance.updateVisibility. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph