Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim: startedSimConstructorEmitter and endedSimConstructionEmitter #442

Closed
pixelzoom opened this issue Sep 10, 2017 · 1 comment
Closed

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 10, 2017

I ran into this while looking for something that fires after the Sim is up an running.

In Sim.js:

// @public (phet-io) Emitter for PhET-iO data stream to describe the startup sequence
this.startedSimConstructorEmitter = new Emitter();

// @public (phet-io) Emitter for PhET-iO data stream to describe the startup sequence
this.endedSimConstructionEmitter = new Emitter();

Problems here....

(1) One is named "Constructor", the other "Construction". Tricky.

(2) The documentation tells us nothing about when these fire. And it's not at all clear from reading the code: startedSimConstructorEmitter isn't at the very beginning of the constructor. endedSimConstructionEmitter is in async code that appears in start.

(3) Are these for use only by PhET-iO?

@zepumph
Copy link
Member

zepumph commented Oct 24, 2017

statedSimConstructorEmitter doesn't exist anymore. endedSimConstructionEmitter can be used by anyone like LegendsOfLearnerSupport does. Doc has been improved. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants