Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen loading bar border is not symmetrical #400

Closed
phet-steele opened this issue Jan 25, 2017 · 11 comments
Closed

Splash screen loading bar border is not symmetrical #400

phet-steele opened this issue Jan 25, 2017 · 11 comments
Assignees

Comments

@phet-steele
Copy link

The left side of the loading bar is just ever so slightly thinner than the right side:

screen shot 2017-01-25 at 1 45 25 pm

Seen on macOS 10.12.3 Chrome. For phetsims/tasks/issues/764.

@samreid
Copy link
Member

samreid commented Jan 25, 2017

This appears to be an svg aliasing problem.

@samreid
Copy link
Member

samreid commented Jan 25, 2017

Upon closer inspection, it seems like the left side is getting clipped, perhaps the svg bounding box isn't wide enough to account for the stroke width.

@jonathanolson
Copy link
Contributor

Explicit width/height (and ideally namespace xmlns='http://www.w3.org/2000/svg') in the SVG element itself may fix this. Viewbox could also be used, but is more complicated.

@samreid
Copy link
Member

samreid commented Feb 9, 2017

@samreid
Copy link
Member

samreid commented Feb 9, 2017

Joist, brand and chipper have branches "splash-script" for this.

@samreid
Copy link
Member

samreid commented Feb 9, 2017

Those branches are too stale to work with master.

@samreid
Copy link
Member

samreid commented Feb 9, 2017

I merged master to the branches without any hassle. Here is the div as shown in the chrome dev tools:

image

@samreid
Copy link
Member

samreid commented Feb 9, 2017

Putting x at 1 instead of 0 seems to solve the problem:

image

Is it still aligned, or should I subtract off some width?

@samreid
Copy link
Member

samreid commented Feb 9, 2017

Here are guides that show how bad the alignment is:

image

it would be good to clean that up.

samreid added a commit to phetsims/energy-skate-park-basics that referenced this issue Feb 10, 2017
@samreid
Copy link
Member

samreid commented Feb 10, 2017

@phet-steele
Copy link
Author

This is what I see, and it looks fine to moi:

screen shot 2017-02-10 at 12 39 54 pm

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants