New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y issue in NavigationBarScreenButton #375

Closed

pixelzoom opened this issue Nov 29, 2016 · 1 comment

Assignees

Contributor

pixelzoom commented Nov 29, 2016 •

edited

Loading

@jessegreenberg Please address this TODO item in NavigationBarScreenButton:

66 // TODO: do we have to wrap this with a translated string, to say "Switch to ...", etc.?
67 domElement.value = screen.name;

pixelzoom added the dev:a11y label

pixelzoom assigned jessegreenberg

jessegreenberg added a commit that referenced this issue


          remove TODO comment in NavigationBarScreenButton, see #375

817cc12

Contributor

jessegreenberg commented Nov 29, 2016

I removed the TODO comment since this is more generally going to be addressed with issue #355.

jessegreenberg closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment