-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Heart Beat' div should be hidden from screen readers #310
Comments
Looking over #140, I can not reproduce the 'unresponsive sim' issue with Mac OS Safari 9.0.2 when the heartbeat div is removed. |
'aria-hidden' successfully hides the div from NVDA. |
It may be best to hide the entire 'sim' div from the screen reader. A new issue came up where some of the visual text can be found by screen readers. Something like this might work:
|
This in combination with the change in phetsims/scenery#504 seems to work very nicely with NVDA + Chrome/Firefox. Ran through test-server, no issues related to the change. |
This was completed, |
In #140, a 'heartBeat' div was introduced to Sim.js to keep the sim awake for Mac OS with Safari. The div contains a random number that changes every thirty seconds or so.
The div can be found by screen readers so that when the AT reads through the document, the last thing it reads is the random heart beat value. The user can also find the number with the virtual cursor.
The
hidden
attribute could be used to hide the div from the screen reader. Another possibility is thearia-hidden
attribute. The div would look like:These attributes might hide the heart beat from the browser and remove functionality of the div.
Assigning to @jessegreenberg to test and implement.
The text was updated successfully, but these errors were encountered: