-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale the splash screen logo based on the size of the screen #309
Comments
I suppose that would be nice, but seems extremely low priority unless it would make the code cleaner/more consistent. |
I wouldn't bother with this, unlikely that the user will resize the browser window while the sim is loading, and if they do, not a big deal because it doesn't compromise functionality of the sim. Consider addressing this if/when animation is added to the splash, in #68. |
I suspect this issue will become more important if/when we start targeting smaller devices (where the logo currently fills the whole screen or even goes offscreen). |
Folded this issue into #309, where the splash screen is getting a redesign. |
Everything in a PhET simulation scales to fit the window except the splash screen logo/text. Should this scale as well? Tagging @ariel-phet @pixelzoom for discussion.
The text was updated successfully, but these errors were encountered: