Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3rd party licenses into the UI (perhaps somewhere in the about dialog) #252

Closed
samreid opened this issue Jun 24, 2015 · 1 comment
Closed

Add 3rd party licenses into the UI (perhaps somewhere in the about dialog) #252

samreid opened this issue Jun 24, 2015 · 1 comment
Labels
type:licensing

Comments

@samreid
Copy link
Member

samreid commented Jun 24, 2015

#71 discusses about dialog refinements. One additional step that could be taken would be to include the 3rd party contribution license texts into a new tab in the about dialog. We may not be required to do this to meet the letter of the law, but it could still be a good thing to do to be "good citizens".
@samreid samreid mentioned this issue Jun 24, 2015
Closed
@samreid
Copy link
Member Author

samreid commented Jul 24, 2015

We decided to just put a link in the About dialog that says "Third-party credits". You can track the progress of the link working in this issue: https://github.com/phetsims/website/issues/255 Closing.

@samreid samreid closed this as completed Jul 24, 2015
jessegreenberg added a commit that referenced this issue May 12, 2017
@jessegreenberg
prevent firefox bug where focus gets trapped when browser navbar hidd…
cc645a0 
…en and only one focusable element in DOM, see #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:licensing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid