Can the homescreen & navbar buttons be rewritten using the new Sun.buttons?

[samreid]

Can the homescreen & navbar buttons be rewritten using the new Sun.buttons?

[samreid]

Did @jonathanolson do any work on this in scenery/02? I have a vague recollection about something similar.

[samreid]

This relates somewhat to phetsims/sun#94 (comment)

[jonathanolson]

See https://github.com/phetsims/joist/blob/ohtwo/js/NavigationBarScreenButton.js

[jonathanolson]

Which might have already been merged back? Were the navbar buttons possible to write with Sun.button?

[samreid]

I asked if the navbar scene selection buttons could be implemented with RadioButtonGroup here: phetsims/sun#127 We still need to address the other joist buttons though. And I thought we backported the ohtwo work you did to joist/01.

[samreid]

Fixing this issue may help with #160

[samreid]

In phetsims/sun#94 @pixelzoom proposed that @pixelzoom work on this.

[samreid]

Here is @pixelzoom comment from phetsims/sun#94

joist is a little more involved. It relies on the old PushButtonDeprecated look for the Home and 'PhET' buttons. Ideally we'd like a version of the sun buttons that take images, but we are unlikely to have that for awhile. In the meantime, I think it would be reasonable to rework/promote PushButtonDeprecated to a simple ImagePushButton. (Consult #37 when creating ImagePushButton.)

Note that the Home and PhET buttons are two of the buttons that should be rewritten to use sun. We could also implement the "screen" icons that appear on the homescreen and in the navbar.

[pixelzoom]

There's no reason to rewrite the home screen and navbar using sun push buttons if RadioButtonGroup is going to handle it (see phetsims/sun#127). Which approach are we taking?

[pixelzoom]

As a result of #170, PhetButton and HomeButton now use sun.NodesPushButton.

The navbar and home screen are still rolling their own buttons:
• NavigationBar uses NavigationBarScreenButton, which uses PushButtonModel and ButtonListener). home screen. Looks like it could be modified to use NodesPushButton.
• HomeScreen is sort of a mess. And it doesn't use anything from sun.

[pixelzoom]

Tackling the home screen and navbar screen icons is going to be a lot of work, more than I have time for. And both the home screen and navbar could benefit from a thorough cleanup. So I'm going to unassign this. If someone else wants to tackle this, go for it.

[pixelzoom]

Duplicate of #183, closing.