Skip to content

Commit

Permalink
sim components voice again when all popups are hidden, only when 'Sim…
Browse files Browse the repository at this point in the history
… Voicing' is enabled, see phetsims/ratio-and-proportion#541
  • Loading branch information
jessegreenberg committed Dec 16, 2022
1 parent caf5a6b commit 872b6af
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion js/Sim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,10 @@ export default class Sim extends PhetioObject {
if ( isModal ) {
this.modalNodeStack.remove( popup );
if ( this.modalNodeStack.length === 0 ) {
this.setNonModalVoicingVisible( true );

// After hiding all popups, Voicing becomes enabled for components in the simulation window only if
// "Sim Voicing" switch is on.
this.setNonModalVoicingVisible( voicingManager.voicingFullyEnabledProperty.value );

// pdom - when the dialog is hidden, make all ScreenView content visible to assistive technology
this.setPDOMViewsVisible( true );
Expand Down

0 comments on commit 872b6af

Please sign in to comment.