add "Voice:" to name response, #813

phetsims · Jun 8, 2022 · 728b223 · 728b223
1 parent e445764
commit 728b223
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/joist-strings_en.json b/joist-strings_en.json
@@ -363,6 +363,9 @@
                 "title": {
                   "value": "Voice"
                 },
+                "titlePattern": {
+                  "value": "Voice: {{value}}"
+                },
                 "noVoicesAvailable": {
                   "value": "No voices available"
                 }

diff --git a/js/joistStrings.ts b/js/joistStrings.ts
@@ -192,6 +192,7 @@ type StringsType = {
               'writtenVariablesPattern': string;
               'voice': {
                 'title': string;
+                'titlePattern': string;
                 'noVoicesAvailable': string;
               };
               'rate': {

diff --git a/js/preferences/VoicingPanelSection.js b/js/preferences/VoicingPanelSection.js
@@ -60,6 +60,7 @@ const voicingHintsString = joistStrings.a11y.preferences.tabs.audio.voicing.simV
 const hintsMutedString = joistStrings.a11y.preferences.tabs.audio.voicing.simVoicingOptions.helpfulHints.disabledAlert;
 
 const voiceLabelString = joistStrings.a11y.preferences.tabs.audio.voicing.customizeVoice.voice.title;
+const voiceTitlePatternLabelString = joistStrings.a11y.preferences.tabs.audio.voicing.customizeVoice.voice.titlePattern;
 const noVoicesAvailableString = joistStrings.a11y.preferences.tabs.audio.voicing.customizeVoice.voice.noVoicesAvailable;
 
 const customizeVoiceExpandedString = joistStrings.a11y.preferences.tabs.audio.voicing.customizeVoice.expandedAlert;
@@ -431,6 +432,8 @@ class VoiceComboBox extends ComboBox {
       listPosition: 'above',
       accessibleName: voiceLabelString,
 
+      comboBoxVoicingNameResponsePattern: voiceTitlePatternLabelString,
+
       // phet-io, opt out because we would need to instrument voices, but those could change between runtimes.
       tandem: Tandem.OPT_OUT
     }, options );