Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-valuetext doesn't update interacting with mouse #330

Closed
zepumph opened this issue Mar 26, 2019 · 5 comments
Closed

aria-valuetext doesn't update interacting with mouse #330

zepumph opened this issue Mar 26, 2019 · 5 comments
Labels

Comments

@zepumph
Copy link
Member

zepumph commented Mar 26, 2019

Discovered as part of phetsims/scenery#951. I would expect the Property passed in to AccessibleSlider to update appropriately no matter what the input modality is, but it seems like the Property only changes when using a keyboard, and thus, only the aria-valuetext in the PDOM updates when using the keyboard.

I don't know much about this sim, but I figured this deserved a low-ish priority issue just to track the bug.

@zepumph
Copy link
Member Author

zepumph commented Mar 26, 2019

Tagging @jessegreenberg so he is aware.

@jessegreenberg
Copy link
Contributor

Hmm, this seems like it would be a general issue for all things that use AccessibleSlider, but Ill take a look as part of phetsims/scenery#951 review.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Apr 11, 2019

It looks like not just aria-valuetext but slider value as well. I confirmed that this is not an issue for other things using AccessibleSlider.

@jessegreenberg
Copy link
Contributor

It is because the AppendageNode gives the AccessibleSliider a Dynamic bidirectional Property to map from angle to input value along the slider ranges.

@jessegreenberg
Copy link
Contributor

Fixed with the above commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants