Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credits #320

Open
jbphet opened this issue Oct 26, 2018 · 9 comments
Open

Update credits #320

jbphet opened this issue Oct 26, 2018 · 9 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Oct 26, 2018

I made a bit of a last-minute update to the credits to add myself and @Ashton-Morris when publishing the 1.5.0 version. I added myself to the "team" field and @Ashton-Morris to the "contributors". I'm not sure if this is considered appropriate - perhaps I should go into the "softwareDevelopment" field and Ashton should be on the team.

Assigning to @ariel-phet to see if he would recommend any changes.

@ariel-phet
Copy link

@jbphet this seems like a good question for @emily-phet.

  1. Since we will be having a fair bit of sound design being done in the future, we could consider updating these categories...for instance changing "Graphic Arts" to "Media" or something like that, or adding a category for "Sound Design". I think that is best to defer to Emily, and I am fine with her call.

  2. As for you, I think that is up to you. I feel like on this particular sim you were more part of the "team" than the software development, but obviously plenty of software development was done. So really your call, I am fine either way.

  3. As for @Ashton-Morris, good to get @emily-phet opinion, but would be curious on his thoughts as well.

@terracoda
Copy link
Contributor

I just happen to notice that under contributors the affiliation of the Jon and Justin (Inclusive Design Research Centre) now also seems to include Ashton which is misleading.

@Ashton-Morris
Copy link

I'd prefer to be credited as Ashton Morris: Sound Designer if possible.

If there is a reason not to than I'll defer to what everyone thinks is best.

jbphet added a commit that referenced this issue Oct 31, 2018
jbphet added a commit that referenced this issue Nov 1, 2018
jbphet added a commit that referenced this issue Nov 1, 2018
jbphet added a commit that referenced this issue Nov 1, 2018
jbphet added a commit that referenced this issue Nov 1, 2018
@jbphet
Copy link
Contributor Author

jbphet commented Nov 1, 2018

I've added @Ashton-Morris as a sound designer and made other updates. This was deployed in v1.5.1 and also fixed on master. Should be good to go, closing.

@terracoda
Copy link
Contributor

In next deployment, can we add Brianna Tomlinson to the team list, after Taliesin Smith, please.

Screen shot from today (June 18, 2019)
jt-credit

@jbphet, tagging you because you updated the credits last time, but I am not sure who should be assigned.

@jessegreenberg
Copy link
Contributor

This issue has been replace by another in a recent publication of JT, #446. I didn't notice this one and Brianna was not added. @terracoda should she still be added?

@terracoda
Copy link
Contributor

Yes, Brianna should still be added.

@terracoda
Copy link
Contributor

This is a copy of the sim's About page on Master on Aug 1, 2022
image

I think two names are missing now from the Team List:

  • Brianna Tomlinson
  • Matthew Moore

Let's make sure these names are not missed in the next maintenance release or next deployment.
BT's name should go after mine, and MM's name should go after Emily.

Apologies, I never assigned this issue back to you @jessegreenberg, after answering your question :-)

@terracoda
Copy link
Contributor

I added a couple of labels in case that helps.

@zepumph zepumph removed the dev:a11y label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants