-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update credits #320
Comments
@jbphet this seems like a good question for @emily-phet.
|
I just happen to notice that under contributors the affiliation of the Jon and Justin (Inclusive Design Research Centre) now also seems to include Ashton which is misleading. |
I'd prefer to be credited as Ashton Morris: Sound Designer if possible. If there is a reason not to than I'll defer to what everyone thinks is best. |
I've added @Ashton-Morris as a sound designer and made other updates. This was deployed in v1.5.1 and also fixed on master. Should be good to go, closing. |
In next deployment, can we add Brianna Tomlinson to the team list, after Taliesin Smith, please. Screen shot from today (June 18, 2019) @jbphet, tagging you because you updated the credits last time, but I am not sure who should be assigned. |
This issue has been replace by another in a recent publication of JT, #446. I didn't notice this one and Brianna was not added. @terracoda should she still be added? |
Yes, Brianna should still be added. |
This is a copy of the sim's About page on Master on Aug 1, 2022 I think two names are missing now from the Team List:
Let's make sure these names are not missed in the next maintenance release or next deployment. Apologies, I never assigned this issue back to you @jessegreenberg, after answering your question :-) |
I added a couple of labels in case that helps. |
I made a bit of a last-minute update to the credits to add myself and @Ashton-Morris when publishing the 1.5.0 version. I added myself to the "team" field and @Ashton-Morris to the "contributors". I'm not sure if this is considered appropriate - perhaps I should go into the "softwareDevelopment" field and Ashton should be on the team.
Assigning to @ariel-phet to see if he would recommend any changes.
The text was updated successfully, but these errors were encountered: