Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electric discharge sound stops when a long duration spark is created #304

Closed
jbphet opened this issue Sep 18, 2018 · 1 comment
Closed

Electric discharge sound stops when a long duration spark is created #304

jbphet opened this issue Sep 18, 2018 · 1 comment
Assignees
@jbphet

Comments

@jbphet
Copy link
Contributor

jbphet commented Sep 18, 2018

Originally reported by @ariel-phet in #299:

[O]ne bug I noticed is that if you use the sim in "Van de Graff" mode -- as in if you put JT's hand near the doorknob, get a spark going and continuously rub the foot so there is a constant spark, you will see the constant spark but the "sparking sound" goes away. That seems problematic since the visual/model is not matching up with the produced sound.
@jbphet jbphet self-assigned this Sep 18, 2018
jbphet added a commit that referenced this issue Sep 20, 2018
@jbphet
made the electric discharge a loop so that it can continue to play if…
0c4e8de 
… needed, see #304
@jbphet
Copy link
Contributor Author

jbphet commented Sep 20, 2018

I set the electric discharge sound to be a loop and it seems to have fixed the issue. Closing.

@jbphet jbphet closed this as completed Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbphet