-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppendageNode order of change/input firing #153
Comments
Code review for #128 |
Also as a note about related code: |
I updated the documentation for both #153 (comment) and #153 (comment). |
I agree, that much should be abstracted out for all accessible sliders. #149 suggests a mixin pattern for all kinds of accessible components, and this event handling could be handled there. |
Further abstraction of accessible components is going to be tracked in phetsims/scenery#607, closing this issue. |
It would be helpful near here:
to mention that the input event will fire before the change event (in the case that they both fire). The listener for 'change' was in front, so it took a bit to sort out the logic.
Also, this seems like behavior that would be very common, and should be abstracted out (e.g. #149).
The text was updated successfully, but these errors were encountered: