Skip to content

Commit

Permalink
selfVoicing -> voicing, see phetsims/tasks#1083
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Mar 24, 2021
1 parent 04591f7 commit c575135
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions js/john-travoltage/view/AppendageNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import johnTravoltage from '../../johnTravoltage.js';
import johnTravoltageStrings from '../../johnTravoltageStrings.js';
import Leg from '../model/Leg.js';

const selfVoicingObjectResponsePatternString = johnTravoltageStrings.a11y.voicing.appendageObjectResponsePattern;
const voicingObjectResponsePatternString = johnTravoltageStrings.a11y.voicing.appendageObjectResponsePattern;
const grabbedAlertString = johnTravoltageStrings.a11y.voicing.grabbedAlert;
const grabDragHintPatternString = sceneryPhetStrings.a11y.voicing.grabDragHintPattern;
const selfVoicingContentHintString = johnTravoltageStrings.a11y.voicing.contentHint;
Expand Down Expand Up @@ -63,7 +63,7 @@ class AppendageNode extends Node {
keyboardMidPointOffset: 0, // adjust center position of accessible slider, to align important positions at center

// {string|null} - hint spoken to guide the user toward an interaction
selfVoicingHint: null,
voicingHint: null,
maniupationHint: null
}, options );

Expand Down Expand Up @@ -341,7 +341,7 @@ class AppendageNode extends Node {

let objectResponse;
if ( includeLabel ) {
objectResponse = StringUtils.fillIn( selfVoicingObjectResponsePatternString, {
objectResponse = StringUtils.fillIn( voicingObjectResponsePatternString, {
label: this.labelContent,
valueText: this.ariaValueText
} );
Expand Down
16 changes: 8 additions & 8 deletions js/john-travoltage/view/JohnTravoltageView.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ const screenSummaryBodyDescriptionPatternString = johnTravoltageStrings.a11y.scr
const electronsSingleDescriptionString = johnTravoltageStrings.a11y.electrons.singleDescription;
const electronsMultipleDescriptionPatternString = johnTravoltageStrings.a11y.electrons.multipleDescriptionPattern;
const descriptionWithChargePatternString = johnTravoltageStrings.a11y.screenSummary.descriptionWithChargePattern;
const selfVoicingContentHintString = johnTravoltageStrings.a11y.voicing.contentHint;
const selfVoicingDetailedContentHintString = johnTravoltageStrings.a11y.voicing.detailedContentHint;
const voicingContentHintString = johnTravoltageStrings.a11y.voicing.contentHint;
const voicingDetailedContentHintString = johnTravoltageStrings.a11y.voicing.detailedContentHint;
const overviewPatternString = johnTravoltageStrings.a11y.voicing.overviewPattern;
const resetAllString = sceneryPhetStrings.a11y.resetAll.label;
const resetAllAlertString = sceneryPhetStrings.a11y.resetAll.alert;
Expand Down Expand Up @@ -140,7 +140,7 @@ class JohnTravoltageView extends ScreenView {
labelContent: appendageLegLabelString,

// prototype self-voicing feature
selfVoicingHint: selfVoicingContentHintString,
voicingHint: voicingContentHintString,
manipulationHint: footInteractionHintString
} );
this.addChild( this.leg );
Expand All @@ -153,7 +153,7 @@ class JohnTravoltageView extends ScreenView {
labelContent: appendageArmLabelString,

// prototype self-voicing feature
selfVoicingHint: selfVoicingDetailedContentHintString,
voicingHint: voicingDetailedContentHintString,
manipulationHint: handInteractionHintString
} );
this.addChild( this.arm );
Expand Down Expand Up @@ -409,11 +409,11 @@ class JohnTravoltageView extends ScreenView {
} ) );

const quickControl = new VoicingQuickControl( webSpeaker, {
createDetailsContent: this.createSelfVoicingSceneDescription.bind( this ),
createDetailsContent: this.createVoicingSceneDescription.bind( this ),
createHintContent: () => {
let hintString = selfVoicingContentHintString;
let hintString = voicingContentHintString;
if ( model.electronGroup.count >= 10 ) {
hintString = selfVoicingDetailedContentHintString;
hintString = voicingDetailedContentHintString;
}
return hintString;
},
Expand Down Expand Up @@ -552,7 +552,7 @@ class JohnTravoltageView extends ScreenView {
* @private
* @returns {string}
*/
createSelfVoicingSceneDescription() {
createVoicingSceneDescription() {
const positionDescription = AppendageNode.getPositionDescription( this.arm.a11yAngleToPosition( this.model.arm.angleProperty.get() ), AppendageRangeMaps.armMap.regions );
const johnDescription = StringUtils.fillIn( screenSummaryBodyDescriptionPatternString, { position: positionDescription } );

Expand Down

0 comments on commit c575135

Please sign in to comment.