Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sim should use StringUtils.fillIn #41

Closed
jessegreenberg opened this issue Mar 1, 2018 · 3 comments
Closed

Sim should use StringUtils.fillIn #41

jessegreenberg opened this issue Mar 1, 2018 · 3 comments
Assignees
@mbarlow12
Labels
dev:code-review

Comments

@jessegreenberg
Copy link
Contributor

I see some old usages of StringUtils.format. @mbarlow12 could you please replace usages of StringUtils.format with StringUtils.fillIn?
@jessegreenberg
Copy link
Contributor Author

Hmm, actually, it is used for strings.

force-description-pattern-target_source
force-description-pattern-target_source_value

Were these keys taken from gravity-force-lab? If so maybe we don't want to modify them to make #26 easier? @mbarlow12 do you know?

@jessegreenberg
Copy link
Contributor Author

For #30.

@jessegreenberg
Copy link
Contributor Author

By the way, this was from item

Use named placeholders (e.g. "{{value}} {{units}}") instead of numbered placeholders (e.g. "{0} {1}").

mbarlow12 added a commit that referenced this issue Mar 2, 2018
@mbarlow12
replace StringUtils.format with .fillIn (see #41), update string keys…
303b54c 
… and associated variables (see #41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbarlow12 mbarlow12

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbarlow12 @jessegreenberg