-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISLCModel.forceProperty has a todo #38
Comments
This issue is caused by https://github.com/phetsims/phet-io/issues/1292 -- inability to specify units or other NumberProperty metadata for DerivedProperties. This doesn't need to be solved before 1.0, and I don't know how we'll proceed with https://github.com/phetsims/phet-io/issues/1292, but when I come up with a plan, I'll use this as a test case. |
Thanks @samreid, in that case marking as "deferred" for the 1.0 release. |
Linking this issue to the TODO. |
Addressed above. Now the force appears in the PhET-iO Studio wrapper as a numeric read-only property with the appropriate units: Also, this went through a medium-sized merge, @jessegreenberg or @mbarlow12 can you check that nothing is disturbed? |
Thanks @samreid. Removing deferred label. @mbarlow12 could you review the change? |
Reviewed. All sims seem to be running fine as well. Closing. |
From #30, just marking this as an issue.
units
option for ForceProperty has this TODO:@mbarlow12 and/or @samreid does this need to be addressed?
The text was updated successfully, but these errors were encountered: