Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure every property and function has a visibility annotation #37

Closed
jessegreenberg opened this issue Mar 1, 2018 · 1 comment
Closed

Make sure every property and function has a visibility annotation #37

jessegreenberg opened this issue Mar 1, 2018 · 1 comment
Assignees
@mbarlow12
Labels
dev:code-review

Comments

@jessegreenberg
Copy link
Contributor

From the review checklist:

Verify that every JavaScript property and function has a visibility annotation.

Majority do, but I did see a few throughout that were missing. @mbarlow12 can you go through and make sure all instance functions and properties have a visibility annotation?
@jessegreenberg
Copy link
Contributor Author

For #30.

mbarlow12 added a commit that referenced this issue Mar 2, 2018
@mbarlow12
visibility annotation, see #37
c2b2a8b
mbarlow12 added a commit that referenced this issue Mar 2, 2018
@mbarlow12
JSDoc update, see #37
454ce68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbarlow12 mbarlow12

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbarlow12 @jessegreenberg