Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ISLCObjectNode arrowOptionKeys to constants? #34

Closed
jessegreenberg opened this issue Mar 1, 2018 · 4 comments
Closed

Move ISLCObjectNode arrowOptionKeys to constants? #34

jessegreenberg opened this issue Mar 1, 2018 · 4 comments

Comments

@jessegreenberg
Copy link
Contributor

I believe the options defined in arrowOptionKeys are not instance specific and it might be more conventional to have these documented as a constant above the constructor. @mbarlow12 thoughts?

for #30

@jessegreenberg
Copy link
Contributor Author

Ditto for pullerOptionKeys?

@mbarlow12 mbarlow12 assigned jessegreenberg and unassigned mbarlow12 Mar 2, 2018
@mbarlow12
Copy link
Contributor

@jessegreenberg I'm a little confused on the question. Almost all those options have different values depending on which object and/or sim is creating the instance. I suppose we could create some kind of enum type and simply pass a 'left' or 'right' option at instantiation that would handle the rest of them. Is that the idea?

@jessegreenberg
Copy link
Contributor Author

My thought was that the actual array arrowOptionKeys does not change for each instance, those strings are just iterated with _.pick. It also might be easier to find the arrow specific options if they are closer to the top of the file.

ALIGNMENT_CONTAINER_OPTION_KEYS in AlignBox is kind of what I was thinking.

@mbarlow12
Copy link
Contributor

Ah, yes. Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants