Skip to content

Commit

Permalink
refactoring GravityForceLabAlertManager, and remove unused parameters…
Browse files Browse the repository at this point in the history
…/vars etc, update visibility annotations, phetsims/gravity-force-lab-basics#134
  • Loading branch information
zepumph committed Jun 18, 2019
1 parent f80ea0d commit 301d713
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
8 changes: 2 additions & 6 deletions js/view/ISLCAlertManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ define( require => {
const ActivationUtterance = require( 'SCENERY_PHET/accessibility/ActivationUtterance' );
const inverseSquareLawCommon = require( 'INVERSE_SQUARE_LAW_COMMON/inverseSquareLawCommon' );
const ISLCA11yStrings = require( 'INVERSE_SQUARE_LAW_COMMON/ISLCA11yStrings' );
const PositionDescriber = require( 'INVERSE_SQUARE_LAW_COMMON/view/describers/PositionDescriber' );
const utteranceQueue = require( 'SCENERY_PHET/accessibility/utteranceQueue' );
const ValueChangeUtterance = require( 'SCENERY_PHET/accessibility/ValueChangeUtterance' );

Expand All @@ -27,20 +26,17 @@ define( require => {
/**
* @param {ISLCModel} model
* @param {ForceDescriber} forceDescriber
* @param {PositionDescriber} positionDescriber
*/
constructor( model, forceDescriber, positionDescriber ) {
constructor( model, forceDescriber ) {

assert && assert( positionDescriber instanceof PositionDescriber );
// @protected
this.forceDescriber = forceDescriber;
this.positionDescriber = positionDescriber;
this.model = model;

// @public {Utterance} - utterances to be added to utteranceQueue, can be used to leverage
// alertStableDelay feature so this alert content doesn't hit the user too frequently
this.showForceValuesUtterance = new ActivationUtterance();
this.positionUtterance = new ValueChangeUtterance();
this.positionUtterance = new ValueChangeUtterance(); // TODO: delete me depending on https://github.com/phetsims/gravity-force-lab-basics/issues/146
}

/**
Expand Down
1 change: 0 additions & 1 deletion js/view/describers/ForceDescriber.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ define( require => {
* @public
*/
getScientificNotationAlertText() {

if ( this.scientificNotationProperty.get() ) {
return forcesInScientificNotationString;
}
Expand Down

0 comments on commit 301d713

Please sign in to comment.