New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace '{0}' with NumberDisplay.NUMBERED_PLACEHOLDER #71

Closed

pixelzoom opened this issue Feb 5, 2019 · 1 comment

Assignees

Labels

Contributor

pixelzoom commented Feb 5, 2019 •

edited

Loading

Noted in phetsims/scenery-phet#446.

See:

// AppliedForceControl
 var VALUE_PATTERN = StringUtils.format( pattern0Value1UnitsString, '{0}', newtonsString );

// DisplacementControl
var VALUE_PATTERN = StringUtils.format( pattern0Value1UnitsString, '{0}', metersString );

// SpringConstantControl
  var VALUE_PATTERN = StringUtils.format( pattern0Value1UnitsString, '{0}', newtonsPerMeterString );

pixelzoom added the type:i18n label

pixelzoom self-assigned this

pixelzoom added a commit that referenced this issue


          replace '{0}' with NumberDisplay.NUMBERED_PLACEHOLDER, #71

672ab1f

Contributor Author

pixelzoom commented Feb 5, 2019

Done, closing.

pixelzoom closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment