Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO redesign #69

Open
pixelzoom opened this issue Dec 13, 2018 · 12 comments
Open

PhET-iO redesign #69

pixelzoom opened this issue Dec 13, 2018 · 12 comments

Comments

@pixelzoom
Copy link
Contributor

12/13/18 phetio meeting:

  • publish a dev version with new Studio
  • work with @arouinfar to review the current instrumentation
@pixelzoom
Copy link
Contributor Author

Here's a dev version with revised Studio. Note that nothing is currently "featured", so you'll need to select the "All" radio button to explore what's currently instrumented.

https://phet-dev.colorado.edu/html/hookes-law/1.1.0-dev.14/phet-io/

Things to address in this review:

  • Is there anything that IS NOT instrumented that should be?
  • Is there anything that IS instrumented that should NOT be?
  • Which PhET-iO components should be "features?

@pixelzoom
Copy link
Contributor Author

@arouinfar I don't know what the timeframe or priority is for this issue, but the ball is in your court. Happy to consult with you on this.

@pixelzoom pixelzoom removed their assignment Dec 15, 2018
@arouinfar
Copy link
Contributor

Thanks @pixelzoom. I've got my hands full with the issues that came out of the Wave Interference dev test, but I'll try to revisit this early next week in case I need to touch base with you.

@arouinfar
Copy link
Contributor

@pixelzoom this issue is still on my radar, but I probably won't get to it until after the Google.org deadline at the end of the month.

@pixelzoom
Copy link
Contributor Author

Thanks for the update. Like I said, I have no idea what the priority of this issue is. I'm under the impression (but far from certain) that Graphing Quadratics PhET-iO will be completed before this.

@pixelzoom
Copy link
Contributor Author

In #75, I completed cleanup of the code. As I said in that issue, I did not make any big changes to what was already instrumented, and I did not add any metadata (e.g. phetioFeatured).

This sim is now ready for redesign using Studio. If you encounter any model/view component that does not appear in Studio, please create an issue to have it instrumented.

@pixelzoom pixelzoom changed the title review PhET-iO design PhET-iO redesign Jan 14, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 14, 2021

1/14/2021 PhET-iO meeting:

Ideally @kathy-phet would like this work to be done in 2021. I can proceed with cleaning things up and moving things forward at my discretion. There are currently no milestones for QA and publishing.

FYI @arouinfar @kathy-phet

@pixelzoom pixelzoom assigned pixelzoom and unassigned arouinfar Jan 14, 2021
@pixelzoom
Copy link
Contributor Author

I reviewed the state of this sim, and apparently I already did cleanup circa August 2019 - see #69 (comment). The overrides.js file is currently empty, and the sim is ready for redesign using Studio.

Assigned to @arouinfar and @kathy-phet to handle PhET-iO redesign. Please create new GitHub issues for any change requests.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 4, 2022

Status for 1/4/2022 quarterly-planning meeting:

  • Cleanup has been done.
  • This issue has been assigned to AR & KP for design since 1/21/21.

@pixelzoom
Copy link
Contributor Author

I realize that there were a bunch of Text nodes that had not been instrumented, so did not link back to their stringProperty. Addressed in the above commits.

@arouinfar
Copy link
Contributor

This simulation is not currently a PhET-iO design priority, unassigning.

@pixelzoom
Copy link
Contributor Author

1.1 (#91) will not include PhET-iO, so labeling this as deferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants