Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate ParametricSpringNode to scenery-phet #16

Closed
pixelzoom opened this issue Jul 8, 2015 · 7 comments
Closed

migrate ParametricSpringNode to scenery-phet #16

pixelzoom opened this issue Jul 8, 2015 · 7 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

... along with its test harness (the experimental/ subdirectory), which will probably become a screen in the scenery-phet demo app.

@pixelzoom pixelzoom self-assigned this Jul 8, 2015
@pixelzoom
Copy link
Contributor Author

For anyone who has an opinion...

ParametricSpringNode has an extensive test screen, see hookes-law with "exp" query parameter ("Experimental" screen). I'm sure this test screen will be useful in the future, so I'd like to move it to scenery-phet with ParametricSpringNode. If I add it as a screen to the scenery-phet demo, it will be the demo's 4th screen, and is something that can be built and deployed to dev (if that's important). Should I do that, or should it be a separate app (separate .html file and main.js)?

@samreid
Copy link
Member

samreid commented Jul 8, 2015

It could be some work to extend our build process to handle multiple html files. Since I don't want to engage in that work now (and I don't want ParametricSpringNode's test to be a separate repo), perhaps a 4th screen would be best for now.

@pixelzoom
Copy link
Contributor Author

I'm going to hold off on migration to scenery-phet until the optimizations in #3 are completed.

@pixelzoom
Copy link
Contributor Author

... and until API changes in #9 are completed.

@pixelzoom
Copy link
Contributor Author

API changes in #9 are done, optimization in #3 are done. Time to migrate.

@pixelzoom
Copy link
Contributor Author

This is done. In addition to migrating ParametricSpringNode to scenery-phet, I also migrated NumberControl and NumberDisplay because (a) they seem to be generally useful, and (b) they are used extensively in the demo for ParametricSpringNode.

The demo for ParametricSpringNode is now the "Spring" screen in the scenery-phet demo.

NumberControl was added to the "Sliders" screen of the scenery-phet demo in phetsims/scenery-phet@6464219.

@pixelzoom
Copy link
Contributor Author

All of this code was previously reviewed as part of #2. There was general agreement (see above) that the ParametricSpringNode demo would be added as a 4th screen in the scenery-phet demo. And migration of NumberDisplay and NumberControl was OK'ed during a Skype conversation. So I'm going to go ahead and close this issue. If anyone wants to take a peek, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants