Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple attenuation points on the waves has not been tested #52

Closed
jbphet opened this issue Jul 21, 2021 · 1 comment
Closed

Multiple attenuation points on the waves has not been tested #52

jbphet opened this issue Jul 21, 2021 · 1 comment
Assignees
@jbphet
Labels
priority:5-deferred

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 21, 2021

The design of the Waves screen only shows a single place where a wave might be attenuated. However, it seems to me that we may want to have multiple attenuation points, such as when an IR wave is traveling through the atmosphere. I've designed the code to support this, but have done almost no testing of it. If there comes up time when multiple attenuations are needed, this code will need some wringing out.
@jbphet jbphet self-assigned this Jul 21, 2021
@jbphet jbphet mentioned this issue Jul 8, 2022
Closed
@jbphet
Copy link
Contributor Author

jbphet commented Dec 14, 2022

This feature was added back and was tested, at least to an extent. It will be tested more thoroughly as part of the next prototype publication in #220, so I think it's safe to close this one.

@jbphet jbphet closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
priority:5-deferred
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbphet