Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd font for Celsius and Fahrenheit with Win10 + Chrome #354

Closed
Tracked by #973
Nancy-Salpepi opened this issue Aug 16, 2023 · 6 comments
Closed
Tracked by #973

Odd font for Celsius and Fahrenheit with Win10 + Chrome #354

Nancy-Salpepi opened this issue Aug 16, 2023 · 6 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Aug 16, 2023

For phetsims/qa#970, the font for Celsius and Fahrenheit is different than Kelvin in Win + chrome.
I don't see this with mac + chrome/safari or win + FF.

Win10 + Chrome:

units1
units2

Mac + Chrome:
Screenshot 2023-08-16 at 5 23 49 PM

@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Aug 16, 2023
@jbphet
Copy link
Contributor

jbphet commented Aug 17, 2023

I believe this is due to the fact that I'm using single unicode characters for "degrees Celsius" and "degrees Fahrenheit". I could change this to be two separate characters, since I just checked and there is a separate character for degrees. It may not look quite as compact, but will be more consistent.

@jbphet
Copy link
Contributor

jbphet commented Aug 17, 2023

I went ahead and changed this on the main branch, and I can see the difference on my machine. Below are some screenshots.

Before:

image

image

After:

image

image

@jbphet
Copy link
Contributor

jbphet commented Aug 17, 2023

I just reviewed this with @arouinfar over Zoom, and she and I agree that this seems like an improvement. I'll need to change it in the previously submitted translation files too.

@jbphet
Copy link
Contributor

jbphet commented Aug 17, 2023

This has been fixed for all existing translations as of this moment.

  • Note to self: Check for single-char versions of these units in translations just before publishing, since some could sneak in between now and then.

@jbphet
Copy link
Contributor

jbphet commented Aug 22, 2023

QA - Feel free to close once verified.

@KatieWoe
Copy link
Contributor

Things looked good on Win 11 Chrome and Firefox. Will reopen if anything shows up in other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants