Some values can't be customized using their associated model property

[Nancy-Salpepi]

For phetsims/qa#970

In the examples.md, under Control Sunlight and Infrared Properties, it says that values can be customized using the associated model property, but
greenhouseEffect.layerModelScreen.model.groundLayer.albedoProperty and
greenhouseEffect.layerModelScreen.model.atmosphereLayers.numberOfActiveAtmosphereLayersProperty
are read only and can only be customized through direct interaction with the sim.
Is that OK?

[arouinfar]

Thanks for reporting @Nancy-Salpepi. These properties appear on all screens, which is probably why they are read-only. It would be problematic for clients to change the albedoProperty of the ground on the Waves screen, for example.

@jbphet can you make these properties phetioReadOnly: false on the Layer Model screen only? These properties power UI controls on that screen, and it's reasonable to expect that clients may need to set them with the API.

[jbphet]

@arouinfar - I've committed changes for this, please check it over and assign back to me with your assessment.

[arouinfar]

Things look great on main @jbphet. As requested, back to you.

[jbphet]

Cool. I'll unassign and have it verified by QA in the next round of testing.

[jbphet]

QA - Feel free to close once verified.

[Nancy-Salpepi]

The properties are now phetioReadOnly: false and customizable 🙂.