Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE workaround in PhotonEmissionSoundGenerator.ts #333

Closed
pixelzoom opened this issue Jul 13, 2023 · 1 comment
Closed

IE workaround in PhotonEmissionSoundGenerator.ts #333

pixelzoom opened this issue Jul 13, 2023 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 13, 2023

For code review #331 ...

  • IE is no longer supported. With that in mind remove IE-specific workarounds

I see these 2 workarounds in PhotonEmissionSoundGenerator.ts:

    // Note - can't use initialization constructor for Map due to lack of support in IE.
    const photonInitialEmissionSoundPlayers = new Map();
...
    // Note - can't use initialization constructor for Map due to lack of support in IE.
    const photonEmissionFromMoleculeSoundPlayers = new Map();

I think it's fine the way it is, but wanted to point it out in case @jbphet wants to initialize the Map when it's instantiated.

@jbphet
Copy link
Contributor

jbphet commented Jul 14, 2023

Workaround removed, and the code now uses the Map constructor to set initial values. Closing.

@jbphet jbphet closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants