Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review pointer areas #329

Closed
jbphet opened this issue Jul 13, 2023 · 2 comments
Closed

Review pointer areas #329

jbphet opened this issue Jul 13, 2023 · 2 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 13, 2023

The pointer areas should be reviewed as part of the code review effort.

@jbphet jbphet self-assigned this Jul 13, 2023
@jbphet jbphet mentioned this issue Jul 13, 2023
80 tasks
jbphet added a commit that referenced this issue Jul 18, 2023
@jbphet
Copy link
Contributor Author

jbphet commented Jul 18, 2023

I thought we had done this already when we published the prototype, but when I went through the sim it looked like most of the touch areas were at their default values. I ended up expanding a number of them with the intent of making the sim easier to use on touch-based devices.

@arouinfar - Please review, and let me know what changes you'd like to see. If it's good as is, feel free to close. You can compare to the published version if you want to see how things have changed.

@jbphet jbphet assigned arouinfar and unassigned jbphet Jul 18, 2023
@arouinfar
Copy link
Contributor

Thanks @jbphet. I reviewed on master, and everything looks good. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants