-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent outline around temperature values in combobox #256
Comments
Nice find @Nancy-Salpepi. @jbphet is a nice pixel polish, but I don't think it's necessary for the prototype. |
I have added a fix on both master and the 1.1 branch. |
We have a good working solution for the branch, but after discussion with @jbphet, it would be better to use the nodes, once created, and set dynamically the min width of the number displays. I'll work on doing that for master, since I blocked that commit originally over in phetsims/sun#797. |
Looks good to me. I enhanced the docs a bit, and tested out the behavior, and I think we're good to go. I'm not going to propagate this to the 1.1 branch, since it would be a fair amount of work to update the dependences, and there would be no change to the behavior. I'll have QA verify the behavior in the next RC. |
The gray outline is now the same for all temperature units. |
Test device
MacBook Air (m1 chip)
Operating System
macOS 13.1
Browser
safari and chrome
Problem description
For phetsims/qa#871:
With interactive highlights off, when I move the mouse over the temperature units options in the combobox, I see a gray outline. The size around Kelvin is different from the others.
Also I wasn't sure if that was the intended design or if it should be highlighted like this:
The text was updated successfully, but these errors were encountered: