Surface temperature layer doesn't exactly match artwork below

[Nancy-Salpepi]

Test device
MacBook Air (m1 chip)

Operating System
macoS 13.0.1

Browser
safari 16.1

Problem description
For phetsims/qa#871, the surface temperature layer doesn't exactly match the scene below--leaving lighter areas in a few places where the surface and sky meet.

Visuals

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Greenhouse Effect‬ URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.1.0-rc.1/phet/greenhouse-effect_all_phet.html? Version: 1.1.0-rc.1 2022-12-23 00:15:29 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.1 Safari/605.1.15 Language: en-US Window: 1399x710 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

[jbphet]

I'm impressed that you noticed this! @samreid, @arouinfar, and I just reviewed this, and we feel that it doesn't compromise the pedagogy at all, so if it can be fixed quickly it is worth it, otherwise it should be left as is.

[jbphet]

I've updated this such that the green from the background never peeks through. This was, I think, the most noticeable issue. However, this has caused the edge of the orange glow to be a little above the horizon in a couple of places. These are generally less noticeable because they are often behind buildings and such.

@arouinfar - I've done as much as I can reasonably do on this. From here we can either decide that it is acceptable or we could have @mariahmaephet modify the artwork. I'll leave that up to you.

[arouinfar]

However, this has caused the edge of the orange glow to be a little above the horizon in a couple of places. These are generally less noticeable because they are often behind buildings and such.

I agree. I reviewed with @jbphet and we decided that this version is preferable. In order to match things perfectly, we'd need to work with the graphic artist to update the assets. However, we don't think this cost would be worth the benefit.

[Nancy-Salpepi]

It looks much better in rc.2
There are still a couple of spots where I can see the lighter color in the Ice Age scene, not sure if they are worth the time.

Feel free to close if you don't think it is worth fixing.

[arouinfar]

Feel free to close if you don't think it is worth fixing.

I don't think it's worth fixing because getting a 100% perfect match requires updating the artwork. I do, however, appreciate your attention to detail @Nancy-Salpepi!