Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend making touch area larger for flux meter #245

Closed
Tracked by #885
amanda-phet opened this issue Jan 6, 2023 · 4 comments
Closed
Tracked by #885

Recommend making touch area larger for flux meter #245

amanda-phet opened this issue Jan 6, 2023 · 4 comments

Comments

@amanda-phet
Copy link

Test Device

iPad

Operating System

iOS16

Browser

Safari

Problem Description

For phetsims/qa#871. I can't confirm using showPointerAreas but my guess is the touch area for the flux meter isn't dilated. It sometimes took me a couple tries to grab it, so I recommend making it a little larger (mainly the height could be larger).

Steps to Reproduce

Open sim in English
Go to Layer Model screen
Show flux meter
Drag flux meter to a new position

Visuals

image

Troubleshooting Information

blah

Steps to reproduce:

@arouinfar
Copy link
Contributor

Thanks for the suggestion @amanda-phet!

@jbphet can you vertically dilate the touch area on the flux meter probe? Something along the lines of what was done for the slider thumbs would work.

@arouinfar arouinfar removed their assignment Jan 6, 2023
jbphet added a commit that referenced this issue Jan 9, 2023
@jbphet
Copy link
Contributor

jbphet commented Jan 9, 2023

I've added some dilation in the Y direction on both the 1.1 and master branches. @arouinfar - Does this look good to you? You can try it out on master if you prefer.

image

@arouinfar
Copy link
Contributor

Thanks @jbphet! I tested it out on my phone and the flux meter probe was easy to grab.

@Nancy-Salpepi
Copy link

On the iPad, in rc.2 the flux meter probe was easy to grab on both the Photons and Layer Model screens.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants