Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In arrow cut off in Energy Graph #240

Closed
Tracked by #885
marlitas opened this issue Jan 6, 2023 · 4 comments
Closed
Tracked by #885

In arrow cut off in Energy Graph #240

marlitas opened this issue Jan 6, 2023 · 4 comments
Labels

Comments

@marlitas
Copy link
Contributor

marlitas commented Jan 6, 2023

Test device
Mac

Operating System
OS 13.02

Browser
Chrome

Problem description
phetsims/qa#871
In arrow in Energy Graph is cut off.

Steps to reproduce

  1. Go to the second screen
  2. Start light
  3. Open energy graph and look at left side of In arrow.

Visuals
Screenshot 2023-01-06 at 9 08 25 AM

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Greenhouse Effect‬
URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.1.0-rc.1/phet/greenhouse-effect_all_phet.html
Version: 1.1.0-rc.1 2022-12-23 00:15:29 UTC
Features missing: applicationcache, applicationcache, touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36
Language: en-US
Window: 1920x944
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@marlitas marlitas added the type:bug Something isn't working label Jan 6, 2023
@Nancy-Salpepi
Copy link

This is seen on the Waves screen as well

@marlitas
Copy link
Contributor Author

marlitas commented Jan 6, 2023

Also seen in Layer Model screen.

jbphet added a commit that referenced this issue Jan 9, 2023
@jbphet
Copy link
Contributor

jbphet commented Jan 9, 2023

This is happening because there is a clipping area around the bar chart, and it is based on the initial size of the bar chart, and the arrowheads extend just a little bit beyond that initial size in the x direction. I've dilated the clip area to compensate, and it appears to work well. This fix has been committed on both the master and 1.1 branches.

@Nancy-Salpepi
Copy link

Looks good in rc.2. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants