Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound from Waves screen heard on other screens #238

Closed
Tracked by #885
Nancy-Salpepi opened this issue Jan 6, 2023 · 5 comments
Closed
Tracked by #885

Sound from Waves screen heard on other screens #238

Nancy-Salpepi opened this issue Jan 6, 2023 · 5 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
macOS 13.0.1

Browser
safari 16.1

Problem description
For phetsims/qa#871, if the Waves Screen is playing, I can hear a humming sound when I switch to the other 2 screens.

Steps to reproduce

  1. On the Waves Screen, press Start Sunlight button
  2. Wait until the sunlight hits the surface and then switch to either the Photons or Layer Model screen

Visuals

IMG_7805.MOV
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Greenhouse Effect‬ URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.1.0-rc.1/phet/greenhouse-effect_all_phet.html Version: 1.1.0-rc.1 2022-12-23 00:15:29 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.1 Safari/605.1.15 Language: en-US Window: 1399x710 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added type:bug Something isn't working dev:sound labels Jan 6, 2023
@Nancy-Salpepi
Copy link
Author

This issue is specific to the Waves screen. If I start on a different screen and then switch over, I don't hear any sound.

@amanda-phet
Copy link

amanda-phet commented Jan 6, 2023

I think I isolated it to the "greenhouse gas concentration" sound on the Waves screen, if that helps. If greenhouse gas concentration is high, the sound is easy to hear when you switch screens, or even return to the home screen.

@arouinfar
Copy link
Contributor

Thanks @Nancy-Salpepi @amanda-phet.

@jbphet the sound for the redirected IR is leaking through to other screens. As @amanda-phet points out, it's easiest to hear if you maximize the greenhouse gas concentration. This would be good to fix for the prototype.

@jbphet
Copy link
Contributor

jbphet commented Jan 9, 2023

I fixed this by associating the main view node with the loop for this sound. This change was also pushed to the 1.1 branch.

@Nancy-Salpepi
Copy link
Author

This looks fixed in rc.2. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants