Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten time period descriptions #200

Closed
3 tasks done
Tracked by #825
arouinfar opened this issue Aug 4, 2022 · 2 comments
Closed
3 tasks done
Tracked by #825

Shorten time period descriptions #200

arouinfar opened this issue Aug 4, 2022 · 2 comments

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Aug 4, 2022

We currently describe the time periods in three places:

  1. Scene Summary: time period is the {{year seventeen fifty}} and there is {{a farm}}.
  2. Time Period radio button responsive descriptions: Now there is {{a farm}} in observation window.
  3. Explore Mode radio button responsive descriptions: Currently, the time period is the {{year seventeen fifty}} and there is a {{farm}}.

@Matthew-Moore240 and I would like to make these changes.

  • For 2020, change the wording from "a large number" to "many".
  • In case (2) shorten things to: Now {{time period description}}.
    • 2020: Now {{many homes and factories}}.
    • 1950: Now {{a few homes and factories}}.
    • 1750: Now {{a farm}}.
    • Ice Age: Now {{a large glacier}}.
  • In case (3) shorten things to: Time period is the {{year seventeen fifty}}. (This is already included in Further updates to Explore Mode RadioButtonGroup Responsive Descriptions #199.)
@jessegreenberg
Copy link
Contributor

I think I have the above changes complete. Changes were needed for string patterns and logic for each of the above cases so @arouinfar or @Matthew-Moore240 can you make sure each look correct when you verify this issue?

@arouinfar
Copy link
Contributor Author

Looks good, thanks @jessegreenberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants