-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications to the initial version of the Flux Meter #188
Comments
I did the two items listed above, but I'd like to also drag prompt arrows before having the design team check it out. |
Reviewed in today's design meeting, action items are:
|
I have added phet-io control of the cueing arrows for the flux sensor, since this was requested during the last design meeting. It was recommended that I look at the approaches used in molecule-polarity and geometric-optics, but it turns out that these two sims handle phet-io control of their cueing arrows pretty differently. I opted for the approach used in geometric-optics, where there is one global value that is used to control the visibility of these arrows on all screens. @arouinfar - Please review what I've done and see if you're good with it. It works in phet-io Studio, so you can test it there. Also, please let me know if you think we should use a more specific name than If you're good with everything, this issue can be closed. |
@jbphet made some tweaks and the team reviewed in the 9/14/22 design meeting. In general, we liked the changes but recommended reducing the padding between the Visible/Infrared titles and the grid lines to be more similar to the bottom padding. Looks like @jbphet may have already made that change, here's what it looks like in master: I think it looks good, so deferring to @jbphet to decide whether we should close or review in design meeting with the full team. |
We looked at this in the last design meeting, and the team agreed that the spacing now looks good. I think this can be safely closed now. |
Discussed with @kathy-phet on 6/29/2022:
The text was updated successfully, but these errors were encountered: