Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to the initial version of the Flux Meter #188

Closed
jbphet opened this issue Jun 29, 2022 · 6 comments
Closed

Modifications to the initial version of the Flux Meter #188

jbphet opened this issue Jun 29, 2022 · 6 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 29, 2022

Discussed with @kathy-phet on 6/29/2022:

  • Yes, we should modify the flux sensor to span the bulk of the observation window. It would be nice if it still looked like a probe, so perhaps a thin rectangle and a tight connection to the meter
  • @kathy-phet feels that it is confusing that the flux meter doesn't update when the sim is paused and the sensor moves. While it would be possible to make the flux meter update in this case (by tracking the flux at lots of levels in the model), it would be easier to make it blank out and then update once the sim is un-paused. Let's do that for now.
@jbphet
Copy link
Contributor Author

jbphet commented Jul 2, 2022

I did the two items listed above, but I'd like to also drag prompt arrows before having the design team check it out.

@jbphet
Copy link
Contributor Author

jbphet commented Jul 6, 2022

Reviewed in today's design meeting, action items are:

  • Make the cuing arrow colors match the border of the probe
  • Move the cuing arrows to the right side of the probe
  • Instrument these for phet-io, use geometric-optics and molecule-polarity as references for how to do this well

@jbphet
Copy link
Contributor Author

jbphet commented Jul 8, 2022

I have added phet-io control of the cueing arrows for the flux sensor, since this was requested during the last design meeting. It was recommended that I look at the approaches used in molecule-polarity and geometric-optics, but it turns out that these two sims handle phet-io control of their cueing arrows pretty differently. I opted for the approach used in geometric-optics, where there is one global value that is used to control the visibility of these arrows on all screens.

@arouinfar - Please review what I've done and see if you're good with it. It works in phet-io Studio, so you can test it there. Also, please let me know if you think we should use a more specific name than cueingArrowsEnabledProperty, such as fluxSensorCueingArrowsEnabledProperty. The latter just struck me as a little verbose.

If you're good with everything, this issue can be closed.

@jbphet jbphet assigned arouinfar and unassigned jbphet Jul 8, 2022
@jbphet
Copy link
Contributor Author

jbphet commented Sep 9, 2022

I am a bit bothered by how close the tick marks are to the text at the top of the meter now that the background rectangles have been removed. This can be seen in the screenshot below. I asked about it in the design meeting this week, and we decided that I should create a little more space here.

image

@arouinfar
Copy link
Contributor

@jbphet made some tweaks and the team reviewed in the 9/14/22 design meeting. In general, we liked the changes but recommended reducing the padding between the Visible/Infrared titles and the grid lines to be more similar to the bottom padding. Looks like @jbphet may have already made that change, here's what it looks like in master:
image image

I think it looks good, so deferring to @jbphet to decide whether we should close or review in design meeting with the full team.

@arouinfar arouinfar assigned jbphet and unassigned arouinfar Sep 20, 2022
@jbphet
Copy link
Contributor Author

jbphet commented Sep 27, 2022

We looked at this in the last design meeting, and the team agreed that the spacing now looks good. I think this can be safely closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants