-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile VO reads sim title after pressing Start Sunlight button #182
Comments
This puts you back at the top. If you start swiping to read the next item, you have to read through the whole description before reaching the controls again. |
This also seems to occur on other screen readers, such as Jaws, but it is much more noticeable and/or troublesome on Mobile VO due to the comparative limited ability to move focus around. |
Thanks @Nancy-Salpepi and @KatieWoe - This actually makes sense, after the sunlight button is pressed focus is not placed anywhere and it goes to the top of the screen. The screen reader is telling the user where they are after the button disappears. This may or may not be OK. One way to fix it is to place focus somewhere after the "start sunlight" button is pressed. Then it will likely read the name of the newly focused component and then say "Sunlight started." Assigning to @arouinfar and @Matthew-Moore240 to decide if anything should be done. |
For Mobile VO, this sounds like a pretty poor experience. Could we shift focus to H3: Observation Window? That way, screen readers (including Mobile VO) can pick up where they left off. It also won't disturb the focus order of UI elements. Hitting tab should still take users to the Greenhouse Gas Concentration slider. |
I see, makes sense. I think the main thing that will change with this is the heading level that gets read out. This change may or may not prevent VO from reading "article, landmark". Currently we hear:
With this change we could hear
or if we are lucky
We don't have a great way to focus non-interactive elements in the PDOM currently, but we could work on that. @arouinfar just want to confirm this is what you were expecting before spending a bit more time on this issue. |
Yes, that's what I was thinking @jessegreenberg. I'm not particularly worried about "article, landmark" but it seems like better UX to go to the parent H3 rather than all the way back up to the H1. |
OK this is done, I made a new node FocusableHeadingNode to support this. @arouinfar can you please verify that this is working and the PDOM order around the Observation Window is still looking OK for the waves screen? |
The behavior looks good in master @jessegreenberg, but I think this should go back to QA to verify in Mobile VO in the next testing cycle. |
OK sounds good, thanks. Adding the "ready-for-review" label for the next dev test. |
Note to QA: Please close after verifying. |
I was moved up to the url bar in dev.10, phetsims/qa#819. This was on an iPadOS 15 device. |
For me, in dev.10 with iPadOS 15.5 focus moves to Observation Window Heading Level 3 after pressing Start Sunlight button. I believe that is the intended behavior. startsunlight.mov |
I tried again today and it worked properly. I'm not sure what changed/what I did wrong the first time around, but this can probably be closed if you agree @jessegreenberg |
Since QA seems to have verified it and @KatieWoe said, "...this can probably be closed...", I'm going to go ahead and close it. |
Test device
iPad Air II
Operating System
iOS 15.5
Browser
Safari
Problem description
For phetsims/qa#811
After pressing the Start Sunlight Button, mobile VO says the sim title, heading level, and a few other things before saying "sunlight started"
This doesn't occur on my mac with VO.
Visuals
sunlight.mov
The text was updated successfully, but these errors were encountered: