make disposal support (or lack thereof) explicit, see #336

js/common/view/GreenhouseEffectObservationWindow.ts

@@ -77,6 +77,8 @@ class GreenhouseEffectObservationWindow extends Node {
     // https://github.com/phetsims/phet-core/issues/128
     const options = optionize<GreenhouseEffectObservationWindowOptions, StrictOmit<SelfOptions, 'fluxMeterNodeOptions'>, NodeOptions>()( {
 
+      isDisposable: false,
+
       // default position in the GreenhouseEffect sim
       left: GreenhouseEffectConstants.SCREEN_VIEW_X_MARGIN,
       top: GreenhouseEffectConstants.SCREEN_VIEW_Y_MARGIN,

js/common/view/GreenhouseEffectScreenView.ts

@@ -53,6 +53,7 @@ class GreenhouseEffectScreenView extends ScreenView {
                          providedOptions: GreenhouseEffectScreenViewOptions ) {
 
     const options = optionize<GreenhouseEffectScreenViewOptions, SelfOptions, ScreenViewOptions>()( {
+      isDisposable: false,
       useClippingFrame: false,
       energyLegendOptions: { tandem: providedOptions.tandem.createTandem( 'energyLegend' ) }
     }, providedOptions );

js/layer-model/LayerModelScreen.ts

@@ -27,7 +27,8 @@ class LayerModelScreen extends Screen<LayerModelModel, LayerModelScreenView> {
       maxDT: GreenhouseEffectConstants.MAX_DT,
       tandem: tandem,
       name: GreenhouseEffectStrings.screen.layerModelStringProperty,
-      createKeyboardHelpNode: () => new GreenhouseEffectKeyboardHelpContent( { includeFluxMeterHelp: true } )
+      createKeyboardHelpNode: () => new GreenhouseEffectKeyboardHelpContent( { includeFluxMeterHelp: true } ),
+      isDisposable: false
     };
 
     super(

js/layer-model/view/InfraredAbsorbanceSoundPlayer.ts

@@ -14,6 +14,7 @@ import SoundGenerator from '../../../../tambo/js/sound-generators/SoundGenerator
 import TSoundPlayer from '../../../../tambo/js/TSoundPlayer.js';
 import layerModelBaseSliderSound_mp3 from '../../../sounds/layerModelBaseSliderSound_mp3.js';
 import phetAudioContext from '../../../../tambo/js/phetAudioContext.js';
+import Disposable from '../../../../axon/js/Disposable.js';
 
 class InfraredAbsorbanceSoundPlayer extends SoundGenerator implements TSoundPlayer {
 
@@ -85,6 +86,11 @@ class InfraredAbsorbanceSoundPlayer extends SoundGenerator implements TSoundPlay
     this.middleSoundClip.stop();
     this.boundarySoundClip.stop();
   }
+
+  // This is intended to exist for the life of the sim, so disposal is not supported.
+  public override dispose(): void {
+    Disposable.assertNotDisposable();
+  }
 }
 
 greenhouseEffect.register( 'InfraredAbsorbanceSoundPlayer', InfraredAbsorbanceSoundPlayer );

js/layer-model/view/InfraredPanel.ts

@@ -33,6 +33,7 @@ export default class InfraredPanel extends Panel {
       yMargin: PANEL_MARGIN,
       align: 'center' as const,
       fill: GreenhouseEffectColors.controlPanelBackgroundColorProperty,
+      isDisposable: false,
 
       // pdom
       tagName: 'div',

js/layer-model/view/NumberOfLayersSoundPlayer.ts

@@ -15,6 +15,7 @@ import twoAbsorbingLayers_mp3 from '../../../sounds/twoAbsorbingLayers_mp3.js';
 import threeAbsorbingLayers_mp3 from '../../../sounds/threeAbsorbingLayers_mp3.js';
 import TSoundPlayer from '../../../../tambo/js/TSoundPlayer.js';
 import TRangedProperty from '../../../../axon/js/TRangedProperty.js';
+import Disposable from '../../../../axon/js/Disposable.js';
 
 class NumberOfLayersSoundPlayer extends SoundGenerator implements TSoundPlayer {
 
@@ -56,6 +57,11 @@ class NumberOfLayersSoundPlayer extends SoundGenerator implements TSoundPlayer {
   public stop(): void {
     // Nothing to do in this case.
   }
+
+  // This is intended to exist for the life of the sim, so disposal is not supported.
+  public override dispose(): void {
+    Disposable.assertNotDisposable();
+  }
 }
 
 greenhouseEffect.register( 'NumberOfLayersSoundPlayer', NumberOfLayersSoundPlayer );

js/layer-model/view/ShowTemperatureCheckbox.ts

@@ -35,7 +35,8 @@ class ShowTemperatureCheckbox extends Checkbox {
     } );
 
     const options = optionize<ShowTemperatureCheckboxOptions, SelfOptions, CheckboxOptions>()( {
-      boxWidth: 15
+      boxWidth: 15,
+      isDisposable: false
     }, providedOptions );
 
     super( property, thermometerIcon, options );

js/layer-model/view/SolarIntensityControl.ts

@@ -57,7 +57,8 @@ export default class SolarIntensityControl extends VBox {
           maxSoundPlayer: solarIntensitySoundPlayer
         },
         tandem: tandem.createTandem( 'slider' ),
-        phetioVisiblePropertyInstrumented: false
+        phetioVisiblePropertyInstrumented: false,
+        isDisposable: false
       } )
     );
 

js/layer-model/view/SolarIntensitySoundPlayer.ts

@@ -15,6 +15,7 @@ import phetAudioContext from '../../../../tambo/js/phetAudioContext.js';
 import TSoundPlayer from '../../../../tambo/js/TSoundPlayer.js';
 import SoundGenerator from '../../../../tambo/js/sound-generators/SoundGenerator.js';
 import TRangedProperty from '../../../../axon/js/TRangedProperty.js';
+import Disposable from '../../../../axon/js/Disposable.js';
 
 class SolarIntensitySoundPlayer extends SoundGenerator implements TSoundPlayer {
 
@@ -88,6 +89,11 @@ class SolarIntensitySoundPlayer extends SoundGenerator implements TSoundPlayer {
     this.middleSoundClip.stop();
     this.boundarySoundClip.stop();
   }
+
+  // This is intended to exist for the life of the sim, and disposal is not supported.
+  public override dispose(): void {
+    Disposable.assertNotDisposable();
+  }
 }
 
 greenhouseEffect.register( 'SolarIntensitySoundPlayer', SolarIntensitySoundPlayer );

js/layer-model/view/SunlightPanel.ts

@@ -33,6 +33,7 @@ export default class SunlightPanel extends Panel {
       yMargin: PANEL_MARGIN,
       align: 'center' as const,
       fill: GreenhouseEffectColors.controlPanelBackgroundColorProperty,
+      isDisposable: false,
 
       // pdom
       tagName: 'div',

js/layer-model/view/SurfaceAlbedoControl.ts

@@ -57,6 +57,7 @@ export default class SurfaceAlbedoControl extends VBox {
           middleMovingUpSoundPlayer: surfaceAlbedoSoundPlayer,
           middleMovingDownSoundPlayer: surfaceAlbedoSoundPlayer
         },
+        isDisposable: false,
         tandem: tandem.createTandem( 'slider' ),
         phetioVisiblePropertyInstrumented: false
       } )

js/layer-model/view/SurfaceAlbedoSoundPlayer.ts

@@ -15,6 +15,7 @@ import TSoundPlayer from '../../../../tambo/js/TSoundPlayer.js';
 import phetAudioContext from '../../../../tambo/js/phetAudioContext.js';
 import emptyApartmentBedroom06Resampled_mp3 from '../../../../tambo/sounds/emptyApartmentBedroom06Resampled_mp3.js';
 import TRangedProperty from '../../../../axon/js/TRangedProperty.js';
+import Disposable from '../../../../axon/js/Disposable.js';
 
 class SurfaceAlbedoSoundPlayer extends SoundGenerator implements TSoundPlayer {
 
@@ -80,6 +81,11 @@ class SurfaceAlbedoSoundPlayer extends SoundGenerator implements TSoundPlayer {
     this.primarySoundClip.stop();
     this.boundarySoundClip.stop();
   }
+
+  // This is intended to exist for the life of the sim, and disposal is not supported.
+  public override dispose(): void {
+    Disposable.assertNotDisposable();
+  }
 }
 
 greenhouseEffect.register( 'SurfaceAlbedoSoundPlayer', SurfaceAlbedoSoundPlayer );

js/layer-model/view/TemperatureUnitsControl.ts

@@ -66,13 +66,14 @@ class TemperatureUnitsControl extends VBox {
 
     // Put the label and radio buttons together in the VBox.
     super( {
-      tandem: tandem,
       children: [ text, temperatureUnitsRadioButtonGroup ],
       align: 'left',
       spacing: 3,
       visiblePropertyOptions: {
         phetioFeatured: true // see https://github.com/phetsims/greenhouse-effect/issues/318
-      }
+      },
+      tandem: tandem,
+      isDisposable: false
     } );
   }
 }