moved reset up a level in class hierarchy, see #176

phetsims · Jul 1, 2022 · 24f5047 · 24f5047
1 parent 49a85e2
commit 24f5047
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/js/common/view/GreenhouseEffectScreenView.ts b/js/common/view/GreenhouseEffectScreenView.ts
@@ -145,7 +145,10 @@ class GreenhouseEffectScreenView extends ScreenView {
    * Resets view components.
    */
   protected reset(): void {
+
+    // The order here is important - the model must be reset before the observation window.
     this.model.reset();
+    this.observationWindow.reset();
   }
 }
 

diff --git a/js/waves/view/WavesScreenView.ts b/js/waves/view/WavesScreenView.ts
@@ -313,7 +313,6 @@ class WavesScreenView extends GreenhouseEffectScreenView {
 
   public override reset(): void {
     super.reset();
-    this.observationWindow.reset();
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -313,7 +313,6 @@ class WavesScreenView extends GreenhouseEffectScreenView { @@
       public override reset(): void {
         super.reset();
-        this.observationWindow.reset();
       }
     }
@@ Expand Down @@