Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim relies on align:'right' default for Panels #74

Closed
pixelzoom opened this issue Aug 25, 2016 · 1 comment
Closed

sim relies on align:'right' default for Panels #74

pixelzoom opened this issue Aug 25, 2016 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 25, 2016

Related to phetsims/sun#252, this sim uses Panel option minWidth and relies on the old default of align:'right'. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM19976 Panel.js?bust=1472221408000:56Error
    at MassControl.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472221408000:52:15)
    at new MassControl (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/MassControl.js?bust=1472221408000:111:11)
    at new GravityForceLabScreenView (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/GravityForceLabScreenView.js?bust=1472221408000:85:24)
    at Screen.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:35:36)
    at Screen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:134:25)
    at Screen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:439:13)
    at http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:32:5
VM19976 Panel.js?bust=1472221408000:55


>>>> sim relies on align:right
VM19976 Panel.js?bust=1472221408000:56Error
    at MassControl.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472221408000:52:15)
    at new MassControl (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/MassControl.js?bust=1472221408000:111:11)
    at new GravityForceLabScreenView (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/GravityForceLabScreenView.js?bust=1472221408000:89:24)
    at Screen.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:35:36)
    at Screen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:134:25)
    at Screen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:439:13)
    at http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:32:5
VM19976 Panel.js?bust=1472221408000:55 


>>>> sim relies on align:right
VM19976 Panel.js?bust=1472221408000:56 Error
    at MassControl.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472221408000:52:15)
    at new MassControl (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/MassControl.js?bust=1472221408000:111:11)
    at new GravityForceLabScreenView (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/GravityForceLabScreenView.js?bust=1472221408000:93:38)
    at Screen.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:35:36)
    at Screen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:134:25)
    at Screen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:439:13)
    at http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:32:5
VM19976 Panel.js?bust=1472221408000:55 


>>>> sim relies on align:right
VM19976 Panel.js?bust=1472221408000:56 Error
    at MassControl.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472221408000:52:15)
    at new MassControl (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/MassControl.js?bust=1472221408000:111:11)
    at new GravityForceLabScreenView (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab/view/GravityForceLabScreenView.js?bust=1472221408000:97:38)
    at Screen.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:35:36)
    at Screen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:134:25)
    at Screen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472221408000:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472221408000:439:13)
    at http://localhost/~cmalley/GitHub/gravity-force-lab/js/gravity-force-lab-main.js?bust=1472221408000:32:5
@aadish
Copy link
Contributor

aadish commented Aug 30, 2016

fixed closing

@aadish aadish closed this as completed Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants