Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GravityForceLabModel updateForce method should be defined in inherit block #63

Closed
jbphet opened this issue Mar 8, 2016 · 1 comment
Closed

GravityForceLabModel updateForce method should be defined in inherit block #63

jbphet opened this issue Mar 8, 2016 · 1 comment
Assignees
@jbphet
Labels
dev:code-review

Comments

@jbphet
Copy link
Contributor

jbphet commented Mar 8, 2016

There is a method defined in the constructorfor GravityForceLabModel called updateForce. It seems to me that this method can and should be in the inherit block so that it is on the prototype.
aadish added a commit that referenced this issue Mar 9, 2016
@aadish
moving updateForce function from constructor to inherit block, see is…
428ae74 
…sue #63
@aadish aadish assigned jbphet and unassigned aadish Mar 9, 2016
@jbphet
Copy link
Contributor Author

jbphet commented Mar 11, 2016

Looks good, closing.

@jbphet jbphet closed this as completed Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @aadish