Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlMass should extend Panel #61

Closed
jbphet opened this issue Mar 8, 2016 · 1 comment
Closed

ControlMass should extend Panel #61

jbphet opened this issue Mar 8, 2016 · 1 comment
Assignees
@jbphet
Labels
dev:code-review

Comments

@jbphet
Copy link
Contributor

jbphet commented Mar 8, 2016

ControlMass currently extends Node, and adds a Panel to itself, and manually pass through a collection of options. It would simplify the scene graph if this were made to extend Panel, and the options were sent through using the mutate call.

Also, there is a default scale option of 0.8 that doesn't seem to be passed anywhere, and there is currently code in ControlPanel that sets the scale of each mass control to 0.8. I suspect that the first one is ignored, so when this refactor is done, this may end up being double scaled.
aadish added a commit that referenced this issue Mar 9, 2016
@aadish
MassControl is extending from Panel in place of Node, see issue #61
94205b9
@aadish aadish assigned jbphet and unassigned aadish Mar 9, 2016
@jbphet
Copy link
Contributor Author

jbphet commented Mar 11, 2016

Looks good, closing.

@jbphet jbphet closed this as completed Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @aadish