New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PullObject should be PullerNode #59

Closed

jbphet opened this issue Mar 8, 2016 · 1 comment

Assignees

Labels

dev:code-review

Contributor

jbphet commented Mar 8, 2016

The name PullObject is unclear and unconventional, please change it to PullerNode.

jbphet added the dev:code-review label

jbphet assigned aadish

aadish added a commit that referenced this issue


          rename PullObject to PullerNode, see issue #59

e23c3ac

aadish added a commit that referenced this issue


          renaming variables in PullerNode, see issue #59

3fdb4d1

aadish assigned jbphet and unassigned aadish

Contributor Author

jbphet commented Mar 11, 2016

Looks good, closing.

jbphet closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment