Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlShowValues should be renamed #54

Closed
jbphet opened this issue Mar 8, 2016 · 1 comment
Closed

ControlShowValues should be renamed #54

jbphet opened this issue Mar 8, 2016 · 1 comment
Assignees
@jbphet
Labels
dev:code-review

Comments

@jbphet
Copy link
Contributor

jbphet commented Mar 8, 2016

ControlShowValues has been expanded to included a constant radius control. Its original name wasn't the greatest, but now it definitely should be renamed. Something like "ParameterControlPanel" would probably suit.
aadish added a commit that referenced this issue Mar 9, 2016
@aadish
renaming Control Show Values to parameterControlPanel, see issue #54
d9e3173
aadish added a commit that referenced this issue Mar 9, 2016
@aadish
renaming variables in ParameterControlPanel, see issue #54
d680e98
@aadish aadish assigned jbphet and unassigned aadish Mar 9, 2016
@jbphet
Copy link
Contributor Author

jbphet commented Mar 11, 2016

Looks good, closing.

@jbphet jbphet closed this as completed Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @aadish