Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity Force Lab - Republish for PhET-iO with studio save/load #276

Open
zepumph opened this issue Feb 4, 2021 · 4 comments
Open

Gravity Force Lab - Republish for PhET-iO with studio save/load #276

zepumph opened this issue Feb 4, 2021 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Feb 4, 2021

This is a quarterly goal that will hopefully happen in March. @jessegreenberg can you please describe the current state of master for this sim. I know you have been working on self voicing in ISL sims. Would there need to be clean up before this occurs? Are there a11y reasons that we would want to republish this sim for a11y as well? Or perhaps we would just do a PhET-iO version of the sim.

@arouinfar
Copy link

@zepumph I've marked it as blocking sim publication, but I want to make sure you're aware this sim should also get client guides when it is republished, see #274.

@jessegreenberg
Copy link
Contributor

Yes the self voicing code in the ISLC sims is in a prototype state and could use some cleanup before republishing off of master, and would be good to verify that interactive description is not disturbed. I don't think we have a goal to republish this sim for a11y reasons until the self-voicing feature is ready to publish. But that doesn't mean it can't be done, unless that makes it easier for PhET-iO.

This is a quarterly goal that will hopefully happen in March.

Does this mean publication is complete by end of March, and an RC needs to be ready for this sim by about end of Feb?

@zepumph
Copy link
Member Author

zepumph commented Mar 24, 2021

In https://github.com/phetsims/studio/issues/203 it makes things sound like we are instead going with a maintenance release for studio save/load. That will be on hold until GAO is released.

@zepumph
Copy link
Member Author

zepumph commented Apr 8, 2021

In phetsims/studio#203 it makes things sound like we are instead going with a maintenance release for studio save/load. That will be on hold until GAO is released.

This is a lie, we are going to publish off of master. We can wait for self voicing prototype code to clean up though.

@markgammon markgammon changed the title Republish for PhET-iO with studio save/load Gravity Force Lab - Republish for PhET-iO with studio save/load Dec 20, 2021
@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants