Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create phet-io client guides #274

Open
arouinfar opened this issue Jan 14, 2021 · 5 comments
Open

Create phet-io client guides #274

arouinfar opened this issue Jan 14, 2021 · 5 comments

Comments

@arouinfar
Copy link

arouinfar commented Jan 14, 2021

This sim is on the docket to get republished this quarter and will need client guides.

Client guide work is currently blocked by https://github.com/phetsims/phet-io-client-guides/issues/9 and https://github.com/phetsims/studio/issues/202.

@arouinfar
Copy link
Author

The blocking issues have been closed, so I should move forward with the client guides.

@kathy-phet can you forward me the client requests for Gravity Force Lab?

@arouinfar
Copy link
Author

The client guides were created in the above commit, but client-requests.md contains only the generic template info and will be edited once I have the specific client requests for this sim.

@arouinfar
Copy link
Author

Spoke with @kathy-phet and she said that there weren't specific client requests for this sim, but we decided to include just the generic template items. Unfortunately, those generic items are only applicable to multi-screen sims.

This is a bit of a longshot, but @zepumph is there a way to eliminate/skip over client-requests.md during a build so it doesn't end up on the wrapper index page?

@arouinfar arouinfar assigned zepumph and unassigned kathy-phet and arouinfar Feb 9, 2021
@arouinfar
Copy link
Author

Discussed in PhET-iO meeting, and it turns out that the build process is smart enough to skip over non-existent guides. I will delete client-requests.md since there aren't any specific requests for this sim.

@arouinfar arouinfar assigned arouinfar and unassigned zepumph Feb 19, 2021
@arouinfar
Copy link
Author

I deleted client-requests.md in the above commit.

I think the commits in this issue will need to be cherry-picked, so back to @zepumph.

@arouinfar arouinfar assigned zepumph and unassigned arouinfar Feb 19, 2021
@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants