Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "s" on meters when only 1 meter #227

Closed
terracoda opened this issue Jan 1, 2020 · 3 comments
Closed

Remove "s" on meters when only 1 meter #227

terracoda opened this issue Jan 1, 2020 · 3 comments

Comments

@terracoda
Copy link
Contributor

Item 3 from #215 (comment)

I found an "s" on meters when centers were 1 meter apart.
Can you add logic to remove the "s" in that case?

@terracoda
Copy link
Contributor Author

Adding screen shot with VO text
Screen Shot 2019-12-31 at 11 22 39 PM

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Jan 6, 2020
@zepumph
Copy link
Member

zepumph commented Jan 6, 2020

This was a small change in common code, which I like. I will apply to a few other spots too, is that alright? For example the "centers exactly {{distance}} {{unit}}" in the screen summary:

image

Does this feel good to you?

@terracoda
Copy link
Contributor Author

Yes, that looks great! Thanks for finding and fixing these other spots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants